Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed c-blosc2 compilation issue on ppc64le #321

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Fixed c-blosc2 compilation issue on ppc64le #321

merged 1 commit into from
Aug 29, 2024

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Aug 28, 2024

For c-blosc2 on P9, this PR only enables the altivec code and disables all the others.

Otherwise, there is a compilation error:

src/c-blosc2/blosc/shuffle.c: In function ‘blosc_get_cpu_features’:
src/c-blosc2/blosc/shuffle.c:272:29: error: ‘HWCAP_ARM_NEON’ undeclared (first use in this function)
  272 |   if (getauxval(AT_HWCAP) & HWCAP_ARM_NEON) {
      |                             ^~~~~~~~~~~~~~
src/c-blosc2/blosc/shuffle.c:272:29: note: each undeclared identifier is reported only once for each function it appears in
error: command '/usr/bin/powerpc64le-linux-gnu-gcc' failed with exit code 1

The error was due to trying to compile arm code on P9. This code is now explicitly disabled by changing the defined C macros.

@t20100 t20100 added this to the 5.0.0 milestone Aug 28, 2024
@t20100 t20100 requested review from payno and kif August 28, 2024 15:11
@t20100 t20100 merged commit 081095d into silx-kit:main Aug 29, 2024
7 checks passed
@t20100 t20100 deleted the fix-blosc2-ppc64le branch August 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@payno payno payno approved these changes

@kif kif Awaiting requested review from kif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@t20100 @payno